Re: pg_regress cleans up tablespace twice.

On Sat, Jun 20, 2020 at 2:42 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > +ERROR: could not set permissions on directory
> > "C:/projects/postgresql/src/test/regress/testtablespace": Permission
> > denied
> >
> > Any ideas? Here's what it does:
> >
> > https://github.com/macdice/cfbot/tree/master/appveyor
>
> I am not sure, and I am not really familiar with this stuff. Your
> code does a simple vcregress check, and that should take care of
> automatically cleaning up the testtablespace path. The buildfarm uses
> this code for MSVC builds and does not complain, nor do my own VMs
> complain. A difference in the processing after 2b2a070d is that the
> tablespace cleanup/creation does not happen while holding a restricted
> token [1] anymore because it got out of pg_regress.c. Are there any
> kind of restrictions applied to the user running appveyor on Windows?

Thanks for the clue. Appveyor runs your build script as a privileged
user (unlike, I assume, the build farm animals), and that has caused a
problem with this test in the past, though I don't know the details.
I might go and teach it to skip that test until a fix can be found.