| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Full Hash Join |
| Date: | 2023-04-12 21:40:02 |
| Message-ID: | CA+hUKGJ3GwiPpQbfuw6o9YyEzE0CA6fO9qoOEVK-vrfVJCChBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 10, 2023 at 11:33 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sat, Apr 08, 2023 at 02:19:54PM -0400, Melanie Plageman wrote:
> > Another worker attached to the batch barrier, saw that it was in
> > PHJ_BATCH_SCAN, marked it done and detached. This is fine.
> > BarrierArriveAndDetachExceptLast() is meant to ensure no one waits
> > (deadlock hazard) and that at least one worker stays to do the unmatched
> > scan. It doesn't hurt anything for another worker to join and find out
> > there is no work to do.
> >
> > We should simply delete this assertion.
Agreed, and pushed. Thanks!
> I have added an open item about that. This had better be tracked.
Thanks, will update.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-04-12 21:40:18 | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |
| Previous Message | David Rowley | 2023-04-12 21:36:01 | Re: v12: ERROR: subplan "InitPlan 2 (returns $4)" was not initialized |