Re: Context diffs

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Context diffs
Date: 2021-01-04 22:21:07
Message-ID: CA+hUKGJ=Df8jFJcNbhJfCfm_pxP0xVWw+UxM27GwT-4x1k5u=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> * "git apply" and "git am" can't process context diffs (they throw an
> error once a context-like section of the diff is hit; simple
> adding/removing lines in a block works)
>
> * the commit-fest doesn't recognized context diff attachments as
> patches:
>
> https://commitfest.postgresql.org/31/2912/
>
> * cfbot can't process file renames/add/delete from context diffs

For the record, cfbot just uses plain old GNU patch, because that
seems to accept nearly everything that anyone posts here (after a step
that tries to unpack tarballs etc). Several people have suggested I
change it to use git apply instead (IIRC it works better for patches
containing binary files such as cryptographic keys?), but then it
wouldn't accept ye olde context diffs.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-01-04 22:44:29 Re: Handing off SLRU fsyncs to the checkpointer
Previous Message Victor Yegorov 2021-01-04 22:07:13 Re: Deleting older versions in unique indexes to avoid page splits