Re: A qsort template

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org>
Subject: Re: A qsort template
Date: 2022-04-02 20:37:40
Message-ID: CA+hUKG+yW+5cwOyTfyJYOWYpNwXjsvbCq=4CG83HsjRRBvz0yQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Apr 3, 2022 at 8:20 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> @@ -4126,22 +4126,23 @@ copytup_cluster(Tuplesortstate *state, SortTuple *stup, void *tup)

> + stup->isnull1 = false;

Looks like I might have failed to grok the scheme for encoding null
into SortTuple objects. It's clearly uninitialised in some paths,
with a special 0 value in datum1. Will need to look more closely with
more coffee...

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-04-02 21:03:33 Re: A qsort template
Previous Message Andres Freund 2022-04-02 20:37:31 Re: A qsort template