From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Some read stream improvements |
Date: | 2025-02-27 10:09:40 |
Message-ID: | CA+hUKG+x_d9D8WjpXaceN-nbtez+DfJk1S6-u6EiNYXEkNOs4A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 27, 2025 at 11:19 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Feb 26, 2025 at 10:55 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > I was working on expanding tests for AIO and as part of that wrote a test for
> > temp tables -- our coverage is fairly awful, there were many times during AIO
> > development where I knew I had trivially reachable temp table specific bugs
> > but all tests passed.
> >
> > The test for that does trigger the problem described above and is fixed by the
> > patches in this thread (which I included in the other thread):
>
> Thanks. Alright, I'm assuming that you don't have any objections to
> the way I restyled that API, so I'm going to go ahead and push some of
> these shortly, and then follow up with a few newer patches that
> simplify and improve the look-ahead and advice control. More very
> soon.
Ugh, I realised in another round of self-review that that version
could exceed the soft limit by a small amount if the registered
callback pins more buffers underneath it, so not pushed yet. I think
I see how to fix that (namely the alternative design that a comment
already contemplated), more soon...
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2025-02-27 10:20:05 | Re: Some read stream improvements |
Previous Message | Andres Freund | 2025-02-27 10:06:15 | Re: [BUG]: the walsender does not update its IO statistics until it exits |