| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: O_DIRECT on macOS |
| Date: | 2021-05-30 22:31:42 |
| Message-ID: | CA+hUKG+u12tTA3+6R4i-F1A0we3A=LEEwvb_pzM14gpLa5CXOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 31, 2021 at 4:19 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> Should there be an "else" to warn/error in the case that "direct" is requested
> but not supported?
The way we use O_DIRECT currently is extremely minimal, it's just "if
you've got it, we'll use it, but otherwise not complain", and I wasn't
trying to change that yet, but you're right that if we add explicit
GUCs to turn on direct I/O for WAL and data files we should definitely
not let you turn them on if we can't do it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-05-30 23:17:11 | Re: postgres_fdw batching vs. (re)creating the tuple slots |
| Previous Message | Thomas Munro | 2021-05-30 22:29:20 | Re: O_DIRECT on macOS |