| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Some read stream improvements |
| Date: | 2025-02-17 06:03:56 |
| Message-ID: | CA+hUKG+tBTizB4-FdAY_V6r6UBXo-tmEF55h-s+1UfkJieheyw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 17, 2025 at 6:55 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> Just out of curiosity, should we `Assert(*index + n <
> stream->queue_size);` in `read_stream_index_advance_n`?
No: it is allowed to be >= queue_size temporarily, but if so we
subtract queue_size. The result should be equal to (index + n) %
queue_size, assuming small values of n, except we don't want to use %
in hot code. Perhaps we should assert that though!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-02-17 06:18:04 | Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain) |
| Previous Message | Amit Kapila | 2025-02-17 05:59:24 | Re: Introduce XID age and inactive timeout based replication slot invalidation |