Re: Extension Enhancement: Buffer Invalidation in pg_buffercache

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Maksim Milyutin <milyutinma(at)gmail(dot)com>
Cc: Maxim Orlov <orlovmg(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Palak Chaturvedi <chaturvedipalak1911(at)gmail(dot)com>, Jim Nasby <jim(dot)nasby(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache
Date: 2024-04-29 19:17:34
Message-ID: CA+hUKG+rjzQMJ_pWr=hiUXi8KFSgA-zDmXpxm+2fq3BkMh43OA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 30, 2024 at 6:47 AM Maksim Milyutin <milyutinma(at)gmail(dot)com> wrote:
>> Should not we call at the end the StrategyFreeBuffer() function to add target buffer to freelist and not miss it after invalidation?

> Please take a look at this issue, current implementation of EvictUnpinnedBuffer() IMO is erroneous - evicted buffers are lost permanently and will not be reused again

Hi Maksim,

Oops, thanks, will fix.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2024-04-29 19:19:07 Re: Direct SSL connection and ALPN loose ends
Previous Message Tom Lane 2024-04-29 19:15:08 Re: DROP OWNED BY fails to clean out pg_init_privs grants