Re: patch to allow disable of WAL recycling

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch to allow disable of WAL recycling
Date: 2019-03-28 21:47:26
Message-ID: CA+hUKG+pkCF1soq8uyYJxNwQFSqhP=+RY-jD2vdRmF3BFXnOdA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 29, 2019 at 8:59 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Mar 26, 2019 at 3:24 PM Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com> wrote:
> > The latest patch is rebased, builds clean, and passes some basic testing. Please let me know if there is anything else I could do on this.
>
> I agree with Thomas Munro's earlier critique of the documentation.
> The documentation of the new parameters makes an assumption,
> completely unsupported in my view, about when those parameters should
> be set, yet at the same time gives almost no information about what
> they actually do. I don't like that.
>
> The patch needs a visit from pgindent, too.

I would like to fix these problems and commit the patch. First, I'm
going to go and do some project-style tidying, write some proposed doc
tweaks, and retest these switches on the machine where I saw
beneficial effects from the patch before. I'll post a new version
shortly to see if anyone has objections.

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2019-03-28 21:56:11 Syntax diagrams in user documentation
Previous Message Tomas Vondra 2019-03-28 21:19:02 Re: Online verification of checksums