Re: BufFileRead() error signalling

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BufFileRead() error signalling
Date: 2020-01-25 04:11:24
Message-ID: CA+hUKG+fAjDDGxzYT7ya_gTBniLGjx0hZ93KX+EgEEMfF7cXtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 11, 2019 at 2:07 AM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
> You are checking file->dirty twice, first before calling the function and within the function too. Same for the Assert. For example.

True. Thanks for the review. Before I post a new version, any
opinions on whether to back-patch, and whether to do 0003 in master
only, or at all?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-01-25 04:46:28 Re: Error message inconsistency
Previous Message Thomas Munro 2020-01-25 03:45:52 Re: Parallel leader process info in EXPLAIN