| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: pg_upgrade test failure |
| Date: | 2023-01-31 21:08:17 |
| Message-ID: | CA+hUKG+e788-7YMxFEdScS+V_rVYoM6-H+mTS6caoo8oJBzf=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Feb 1, 2023 at 10:04 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On January 31, 2023 12:54:42 PM PST, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> >I'm not sure about anything, but if that's what's happening here, then
> >maybe the attached would help. In short, it would make the previous
> >theory true (the idea of a second unlink() saving the day).
>
> Maybe we should just handle it by sleeping and retrying, if on windows? Sad to even propose...
Yeah, that's what that code I posted would do automatically, though
it's a bit hidden. The second attempt to unlink() would see delete
already pending, and activate its secret internal sleep/retry loop.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-01-31 21:20:23 | Re: pg_upgrade test failure |
| Previous Message | Andres Freund | 2023-01-31 21:04:24 | Re: pg_upgrade test failure |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-01-31 21:20:23 | Re: pg_upgrade test failure |
| Previous Message | Andres Freund | 2023-01-31 21:04:24 | Re: pg_upgrade test failure |