From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Small tidyup for commit d41a178b. |
Date: | 2023-03-17 00:51:28 |
Message-ID: | CA+hUKG+cQxEjAO3ON1W_s4-P9JwH=oLFmwp05g2sKUrk=trBTA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Fri, Mar 17, 2023 at 1:36 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <tmunro(at)postgresql(dot)org> writes:
> > Small tidyup for commit d41a178b.
> > A comment was left behind claiming that we needed to use malloc() rather
> > than palloc() because the corresponding free would run in another
> > thread, but that's not true anymore. Remove that comment. And, with
> > the reason being gone, we might as well actually use palloc().
>
> Hm, doesn't the change to palloc make the following error check redundant?
>
> childinfo = palloc(sizeof(win32_deadchild_waitinfo));
> - if (!childinfo)
> - ereport(FATAL,
> - (errcode(ERRCODE_OUT_OF_MEMORY),
> - errmsg("out of memory")));
> -
> childinfo->procHandle = pi.hProcess;
> childinfo->procId = pi.dwProcessId;
True. Will fix.
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2023-03-17 01:48:58 | pgsql: Small tidyup for commit d41a178b, part II. |
Previous Message | Tom Lane | 2023-03-17 00:36:28 | Re: pgsql: Small tidyup for commit d41a178b. |