| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: hash join error improvement (old) |
| Date: | 2020-05-27 01:46:54 |
| Message-ID: | CA+hUKG+Pews_43h76VvZsXZx4KjKHcwxS9c=kkXJWn2-9Q4oLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 27, 2020 at 1:30 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > There are more uses of BufFileRead that don't bother to distinguish
> > these two cases apart, though -- logtape.c, tuplestore.c,
> > gistbuildbuffers.c all do the same.
>
> Yeah. I rather suspect that callers of BufFileRead/Write are mostly
> expecting that those functions will throw an ereport() for any interesting
> error condition. Maybe we should make it so, instead of piecemeal fixing
> the callers?
Yeah. I proposed that over here:
But I got stuck trying to figure out whether to back-patch (arguably
yes: there are bugs here, but arguably no: the interfaces change).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-27 01:49:16 | Re: some grammar refactoring |
| Previous Message | Kyotaro Horiguchi | 2020-05-27 01:46:27 | Re: max_slot_wal_keep_size comment in postgresql.conf |