| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg15b1: FailedAssertion("val > base", File: "...src/include/utils/relptr.h", Line: 67, PID: 30485) |
| Date: | 2022-06-22 04:33:44 |
| Message-ID: | CA+hUKG+OK_9W4fJJqRzPYraczj++-s8Yz1Ot=Aa=VLGF0L54Ow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 22, 2022 at 4:24 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Jun 22, 2022 at 2:54 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> > > On Wed, Jun 1, 2022 at 2:57 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > >> ... So we can fix this by:
> > >> 1. Using a relative pointer value other than 0 to represent a null
> > >> pointer. Andres suggested (Size) -1.
> > >> 2. Not storing the free page manager for the DSM in the main shared
> > >> memory segment at byte offset 0.
>
> For the record, the third idea proposed was to use 1 for the first
> byte, so that 0 is reserved for NULL and works with memset(0). Here's
> an attempt at that.
... erm, though, duh, I forgot to adjust Assert(val > base). One more time.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-relptr-s-encoding-of-NULL.patch | text/x-patch | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-06-22 04:38:10 | Re: [PROPOSAL] Detecting plan changes with plan_id in pg_stat_activity |
| Previous Message | Noah Misch | 2022-06-22 04:28:14 | Re: Skipping logical replication transactions on subscriber side |