| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Smith <smithpb2250(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-02-24 20:13:47 |
| Message-ID: | CA+hUKG+NO4-1Fbg9+-DQEekqeLtcwGm9KNGyBTW3HiReY9vnwg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 25, 2024 at 9:12 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Sun, Feb 25, 2024 at 8:50 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On GNU/Linux x64, gcc correctly records alignment=2**12 for the associated
> > section (.rodata for bulk_write.o zero_buffer, .bss for pg_prewarm.o
> > blockbuffer). If I'm reading this right, neither AIX gcc nor xlc is marking
> > the section with sufficient alignment, in bulk_write.o or pg_prewarm.o:
>
> Ah, that is a bit of a hazard that we should probably document.
>
> I guess the ideas to fix this would be: use smgrzeroextend() instead
> of this coding, and/or perhaps look at the coding of pg_pwrite_zeros()
> (function-local static) for any other place that needs such a thing,
> if it would be satisfied by function-local scope?
Erm, wait, how does that function-local static object work differently?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2024-02-24 20:26:12 | Re: Relation bulk write facility |
| Previous Message | Thomas Munro | 2024-02-24 20:12:43 | Re: Relation bulk write facility |