Re: pgsql: pgbench: Refactor thread portability support.

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: pgbench: Refactor thread portability support.
Date: 2021-03-10 10:21:29
Message-ID: CA+hUKG+LNCO5ukDxyU7FxXJ_PyZtQTyn-M3vfGS8k-uqnvYUNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Mar 10, 2021 at 9:49 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Mar 10, 2021 at 9:38 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > On Wed, Mar 10, 2021 at 8:51 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > >... I'm now contemplating what's up with hoverfly (some AIX header
> > > problem)...
> >
> > Pushed something for the other two failures seen, but for this one I'm
> > temporarily stumped. We managed to compile all kinds of stuff that
> > surely includes the modified header, and then we get to plpython and
> > we show an error that implies that HAVE_CLOCK_GETTIME is defined and
> > that we included <time.h>, and yet the compiler has never heard of
> > clock_gettime(). It's like someone clobbered someone's include
> > guards, or something of that level of murkiness. Thinking.
>
> Hrrmph. src/pl/plpython/plpython.h's use of #undef _POSIX_C_SOURCE
> looks a bit suspicious.

Fix pushed.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-03-10 14:52:31 pgsql: Add bound check before bsearch() for performance
Previous Message Thomas Munro 2021-03-10 10:21:06 pgsql: Fix another portability bug in recent pgbench commit.