Re: CI CompilerWarnings test fails on 15 in mingw_cross_warning

On Tue, Nov 19, 2024 at 12:09 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> The more interesting patch is 495ed0ef2d7, which did
>
> - collversion = psprintf("%d.%d,%d.%d",
> + collversion = psprintf("%ld.%ld,%ld.%ld",

This platform has sizeof(int) == sizeof(long), so it doesn't matter.

> whereas my patch just did
>
> - collversion = psprintf("%ld.%ld,%ld.%ld",
> + collversion = psprintf("%lu.%lu,%lu.%lu",

I was worried the numbers might have been negative, but those
expressions don't appear to allow that. Strings observed in real life
are like "1539.5,1539.5" (which bears a passing resemblance to an ICU
version, it has a few fairly low-valued human-originated numbers like
a Unicode version swizzled around in a fairly small number of bits,
but it doesn't matter too match how it works, it's enough to see that
we shift down and mask).

So I think it's OK to back-patch that change. See attached.

As for why now, I think both fairywren and CI started warning/failing
about 2 months ago[1][2], and that's when fairywren got a uname -r
upgrade, so I guess msys was upgraded; as for CI I guess you'd have to
check for the relevant ming-cross packages moving in Debian.
Unfortunately there were a lot of random CI failures around that time
and I didn't notice this particular circus at the time.

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2024-10-02%2003%3A57%3A44
[2] https://github.com/postgres/postgres/runs/30890390821