| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Drop type "smgr"? |
| Date: | 2019-02-28 06:02:23 |
| Message-ID: | CA+hUKG+DE0mmiBZMtZyvwWtgv1sZCniSVhXYsXkvJ_Wo+83vvw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello hackers,
The type smgr has only one value 'magnetic disk'. ~15 years ago it
also had a value 'main memory', and in Berkeley POSTGRES 4.2 there was
a third value 'sony jukebox'. Back then, all tables had an associated
block storage manager, and it was recorded as an attribute relsmgr of
pg_class (or pg_relation as it was known further back). This was the
type of that attribute, removed by Bruce in 3fa2bb31 (1997).
Nothing seems to break if you remove it (except for some tests using
it in an incidental way). See attached.
Motivation: A couple of projects propose to add new smgr
implementations alongside md.c in order to use bufmgr.c for more kinds
of files, but it seems entirely bogus to extend the unused smgr type
to cover those.
--
Thomas Munro
https://enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-the-vestigial-smgr-type.patch | application/octet-stream | 12.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-28 06:08:39 | Re: Drop type "smgr"? |
| Previous Message | Tom Lane | 2019-02-28 05:54:55 | Re: reloption to prevent VACUUM from truncating empty pages at the end of relation |