| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Spelling change in LLVM 14 API |
| Date: | 2021-09-24 00:52:09 |
| Message-ID: | CA+hUKG+9ZGWJqTDGE0WyJV_HXmS4DzpQdTbAAQC_V8JKM07oMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 30, 2021 at 5:41 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> - if (F.getAttributes().hasFnAttribute(llvm::Attribute::NoInline))
> + if (F.getAttributes().hasAttribute(llvm::Attribute::FunctionIndex, llvm::Attribute::NoInline))
Yeah, that's already stopped working since you wrote it a few weeks
ago... There's also been a second breakage site in our code due to
LLVM commit 85b732b5. New fix attached. Tested on LLVM 7, 9, 13, 14
(= LLVM main branch commit 945df8bc4cf3 built 2021-09-15).
Even though the macro approach is ugly, we're already handling every
other API change that way, and at least it's at least very clear which
lines to delete in a few years when older LLVMs fall off the conveyor
belt of time. Admittedly renaming an identifiers is a new kludge, but
I didn't want to duplicate the whole if block or confuse pgindent.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Track-LLVM-14-API-changes.patch | text/x-patch | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-09-24 01:31:09 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Justin Pryzby | 2021-09-23 23:56:26 | Re: CLUSTER on partitioned index |