Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.
Date: 2020-01-28 07:41:10
Message-ID: CA+hUKG++GRiv1ELbt8DW4Tw117SiV1EXE_Yc2j8d6JW8xmTDzw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jan 28, 2020 at 6:59 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <tmunro(at)postgresql(dot)org> writes:
> > Remove dependency on HeapTuple from predicate locking functions.
>
> anole's not terribly pleased with this:
>
> "heapam.c", line 9137: error #2118: a void function may not return a value
> return CheckForSerializableConflictOut(relation, xid, snapshot);
> ^

Thanks. I pushed a fix.

Wow, HP C spits out a lot of warnings.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2020-01-28 11:11:46 pgsql: Fix randAccess setting in ReadRecord()
Previous Message Thomas Munro 2020-01-28 07:38:04 pgsql: Fix compile error on HP C.