Re: Resetting spilled txn statistics in pg_stat_replication

On Wed, 7 Oct 2020 at 17:52, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Oct 7, 2020 at 11:24 AM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> >
> > On Tue, 6 Oct 2020 at 17:56, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > On Tue, Oct 6, 2020 at 9:34 AM Masahiko Sawada
> > > <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> > > >
> > > > Looking at pgstat_reset_replslot_counter() in the v8 patch, even if we
> > > > pass a physical slot name to pg_stat_reset_replication_slot() a
> > > > PgStat_MsgResetreplslotcounter is sent to the stats collector. I’m
> > > > okay with not raising an error but maybe we can have it not to send
> > > > the message in that case.
> > > >
> > >
> > > makes sense, so changed accordingly.
> > >
> >
> > Thank you for updating the patch!
> >
>
> Thanks, I will push the first one tomorrow unless I see more comments
> and test-case one later.

I thought we could have a test case for the reset function, what do you think?

> I think after we are done with this the next
> step would be to finish the streaming stats work [1]. We probably need
> to review and add the test case in that patch. If nobody else shows up
> I will pick it up and complete it.

+1
I can review that patch.

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services