Fix pg_buffercache document

From: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Fix pg_buffercache document
Date: 2020-05-07 08:52:40
Message-ID: CA+fd4k6sD8oeP1qJbFAor=rCpYckU9DsywHiYx3x5Hz5Z8Ua_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The following description in pg_buffercace is no longer true.

When the pg_buffercache view is accessed, internal buffer manager
locks are taken for long enough to copy all the buffer state data that
the view will display. This ensures that the view produces a
consistent set of results, while not blocking normal buffer activity
longer than necessary. Nonetheless there could be some impact on
database performance if this view is read often.

We changed pg_buffercache_page so that it doesn't take buffer manager
locks in commit 6e654546fb6. Therefore from version 10,
pg_buffercache_page has less impact on normal buffer activity less but
might not return a consistent snapshot across all buffers instead.

I've attached a patch to fix the documentation.

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
pg_buffercache_doc.patch application/octet-stream 977 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-05-07 08:57:00 Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.
Previous Message Amit Kapila 2020-05-07 08:46:32 Re: PG compilation error with Visual Studio 2015/2017/2019