Re: Fix typo in procarrary.c

From: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix typo in procarrary.c
Date: 2020-08-21 03:29:22
Message-ID: CA+fd4k61kej5xEx6Tbt6HzwTHC7ddm-N1irwt3mqk=Qm0veiNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 21 Aug 2020 at 11:18, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>
>
> On 2020/08/21 10:58, Masahiko Sawada wrote:
> > Hi,
> >
> > I've attached the patch for $subject.
> >
> > s/replications lots/replication slots/
>
> Thanks for the patch!
>
> Also it's better to s/replications slots/replication slots/ ?
>
> --- a/src/backend/storage/ipc/procarray.c
> +++ b/src/backend/storage/ipc/procarray.c
> @@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult
> * be removed.
> *
> * This likely should only be needed to determine whether pg_subtrans can
> - * be truncated. It currently includes the effects of replications slots,
> + * be truncated. It currently includes the effects of replication slots,
> * for historical reasons. But that could likely be changed.
> */
> TransactionId oldest_considered_running;
>

Indeed. I agree with you.

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-08-21 03:39:37 Re: Fix typo in procarrary.c
Previous Message Fujii Masao 2020-08-21 03:22:56 Re: New statistics for tuning WAL buffer size