From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Small doc improvement about spilled txn tracking |
Date: | 2020-06-02 06:18:15 |
Message-ID: | CA+fd4k5EeujyYLnOSvb1wZLLYxpGbpjaVRQXmpAFRJ6yhsrAnw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 2 Jun 2020 at 15:15, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jun 2, 2020 at 11:30 AM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> >
> > On Tue, 2 Jun 2020 at 14:50, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > On Tue, Jun 2, 2020 at 10:22 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > >
> > > > On Tue, Jun 2, 2020 at 9:10 AM Masahiko Sawada
> > > > <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> > > > >
> > > >
> > > > > Please find attached patch.
> > > > >
> > > >
> > > > On a quick look, it seems fine but I will look in more detail and let
> > > > you know if I have any feedback.
> > > >
> > >
> > > I am not sure if we need to add "Logical decoding plugins may
> > > optionally emit tracking message." as the stats behavior should be the
> > > same for decoding plugin and logical replication. Apart from removing
> > > this line, I have made a few other minor changes, see what you think
> > > of attached?
> > >
> >
> > I'm okay with removing that sentence. The patch looks good to me.
> >
>
> Pushed.
Thank you!
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2020-06-02 07:00:19 | Re: Resetting spilled txn statistics in pg_stat_replication |
Previous Message | Masahiko Sawada | 2020-06-02 06:17:36 | Resetting spilled txn statistics in pg_stat_replication |