Re: Unnecessary delay in streaming replication due to replay lag

From: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
To: Asim Praveen <pasim(at)vmware(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hao Wu (Pivotal)" <hawu(at)pivotal(dot)io>
Subject: Re: Unnecessary delay in streaming replication due to replay lag
Date: 2020-08-10 06:57:33
Message-ID: CA+fd4k55xU8+fa0219uM=N-f4D+qOmGc0bHsGfqdqqRXEXSfRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 9 Aug 2020 at 14:54, Asim Praveen <pasim(at)vmware(dot)com> wrote:
>
> I would like to revive this thready by submitting a rebased patch to start streaming replication without waiting for startup process to finish replaying all WAL. The start LSN for streaming is determined to be the LSN that points to the beginning of the most recently flushed WAL segment.
>
> The patch passes tests under src/test/recovery and top level “make check”.
>

The patch can be applied cleanly to the current HEAD but I got the
error on building the code with this patch:

xlog.c: In function 'StartupXLOG':
xlog.c:7315:6: error: too few arguments to function 'RequestXLogStreaming'
7315 | RequestXLogStreaming(ThisTimeLineID,
| ^~~~~~~~~~~~~~~~~~~~
In file included from xlog.c:59:
../../../../src/include/replication/walreceiver.h:463:13: note: declared here
463 | extern void RequestXLogStreaming(TimeLineID tli, XLogRecPtr recptr,
| ^~~~~~~~~~~~~~~~~~~~

cfbot also complaints this.

Could you please update the patch?

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2020-08-10 07:34:24 Re: [PATCH] Covering SPGiST index
Previous Message Anna Akenteva 2020-08-10 06:29:31 Re: Change a constraint's index - ALTER TABLE ... ALTER CONSTRAINT ... USING INDEX ...