| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Subject: | Re: Don't choke on files that are removed while pg_rewind runs. |
| Date: | 2020-07-13 06:59:56 |
| Message-ID: | CA+fd4k4zqu8QxtaxLP3wJmY1ZVqpdWE_ZfSxuJa9__JKCB0y4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 13 Jul 2020 at 15:34, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 13 Jul 2020, at 08:10, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> > Every other access to "res" in this loop is to res(i), which I believe is what
> > was intended here, too. Currently, it will dumbly loop but skip *every* row if
> > the 2nd column (1: size) of the first row (0) is null.
>
> Yeah, I agree with that, seems like the call should've been PQgetisnull(res, i, 1);
> to match the loop.
+1
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2020-07-13 07:01:11 | Re: max_slot_wal_keep_size and wal_keep_segments |
| Previous Message | movead.li@highgo.ca | 2020-07-13 06:46:23 | Re: POC and rebased patch for CSN based snapshots |