From: | Francisco Olarte <folarte(at)peoplecall(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Subject: | Re: pg_rewind exiting with error code 1 when source and target are on the same timeline |
Date: | 2015-10-22 08:52:23 |
Message-ID: | CA+bJJby9zrcz1+oWm1tPw6x7UeO6HqzySZFWAkqWqHoe418OuQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Thu, Oct 22, 2015 at 7:42 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Oct 22, 2015 at 4:08 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> I agree that that should not be an error.
>> But I think in that case we should just delete that check and have the
>> subsequent checks end up at the existing "no rewind required" result.
> I am not sure that I am not getting completely your point, why would
> it be a win to remove this safety check? We surely do not want to look
> for the common ancestor timeline if the target and source nodes have
> the same timeline, so we should not remove this check and just set
> rewind_needed to false to fallback to the same exit(0) for all those
> code paths. Per se the attached for example.
I'm not familiar with pg_rewind, but from a programming perspective I
agree with Peter. If you will end with a no-rewind-required result
when not checking for equality the same timeline check is not a safety
check, but an optimisation. Then removing it can make sense, as
deleted code cannot contain bugs. If searching for the common ancestor
can lead to problems then its a safety check.
Francisco Olarte.
From | Date | Subject | |
---|---|---|---|
Next Message | Artur Zakirov | 2015-10-22 10:16:54 | Re: BUG #13690: Full Text Search with spanish dictionary cannot find some words |
Previous Message | Francisco Olarte | 2015-10-22 08:31:21 | Re: [BUGS] BUG #13695: Problema de autenticación |