Re: Acceptance Tests against a browser (WIP)

Hey Dave,

We re-used one of the test helpers for the 'fix-greenplum-show-tables.diff'
patch, so here is an updated patch which does not include adding that test
helper in case you apply the show-tables patch first. Also, we saw some
strange test behavior yesterday where form fields weren't being filled in
correctly so we changed the way that input fields get filled to be more
reliable.

In short these need to be applied in this order:

> git apply fix-greenplum-show-tables.diff

git apply acceptance-tests-minus-create-table-helper-with-fixed-inputs.diff

We also moved the --exclude flag changes out to a separate patch.

On our side we are still dealing with these as 20 separate commits. What is
the best way for us to send you these patches? Do you prefer having them
all squashed down to a single patch or to have smaller patches?

On Mon, Feb 6, 2017 at 9:54 AM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:

> I agree that we should rename the test. We've renamed it to
> "template_selection_feature_test".
> Your other suggestions are captured in our backlog as future improvements.
> We definitely can and should do those things but I think it would be
> valuable to go ahead and get this suite in and give other devs a chance to
> use and iterate on this work.
>
> Thanks,
>
> Tira & George
>
> On Mon, Feb 6, 2017 at 5:32 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Fri, Feb 3, 2017 at 9:56 PM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:
>> > Hi Dave,
>> >
>> > Here is a new patch which includes the following:
>> > - randomized ports
>> > - delete the acceptance_test_db database in setup in case a prior run
>> failed
>> > - fixed size browser window
>>
>> Definitely getting there :-). A couple of thoughts/questions:
>>
>> - Now there are 2 tests in there, it's clear that both the Python
>> server and browser session are restarted for each test. Can this be
>> avoided? It'll really slow down test execution as more and more are
>> added.
>>
>> - We've got a new monster name:
>> pgadmin.acceptance.tests.sql_template_selection_by_postgres_
>> version_works_feature_test.SQLTemplateSelectionByPostgresVer
>> sionWorksFeatureTest
>> (which on disk is
>> sql_template_select_by_postgres_version_works_feature_test.py). Names
>> like that really must be shortened to something more sane and
>> manageable.
>>
>> - I'm a little confused by why the tests cannot be run in server mode.
>> The error says it's because the username/password is unknown -
>> however, both the pgAdmin and database server usernames and passwords
>> are in test_config.json.
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>