Re: [Patch] Bypass recovery state for Greenplum

From: Atira Odhner <aodhner(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: George Gelashvili <ggelashvili(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] Bypass recovery state for Greenplum
Date: 2017-01-30 16:16:15
Message-ID: CA+Vc24ooAvKC8hNC3i-LvJwr0cESD2QEQ_fAepM63oCJg4DsvA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Whoops we accidentally left in hardcoded db config we used for running
tests from our IDE.

Here's a fixed patch.

On Mon, Jan 30, 2017 at 6:45 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Fri, Jan 27, 2017 at 5:18 PM, George Gelashvili
> <ggelashvili(at)pivotal(dot)io> wrote:
> > This bypasses checking if the DB is in recovery for versions of postgres
> > that don't support pg_is_in_recovery() (anything pre-9.0, such as
> > Greenplum).
> >
> > This patch depends on the "Refactor sql template version picking" patch.
>
> The regression test included with this patch fail for me:
>
> ======================================================================
> ERROR: runTest (pgadmin.browser.server_groups.servers.templates.
> connect.sql.tests.test_check_recovery.TestCheckRecovery)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/templates/connect/sql/tests/test_check_recovery.py",
> line 23, in runTest
> self.server['port']).cursor()
> File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
> 32, in get_db_connection
> port=port)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/psycopg2/__init__.py",
> line 164, in connect
> conn = _connect(dsn, connection_factory=connection_factory,
> async=async)
> OperationalError: fe_sendauth: no password supplied
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Attachment Content-Type Size
bypass-recovery-state-for-greenplum-unhardcodedb.diff text/plain 11.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-01-30 17:03:00 pgAdmin 4 commit: Bypass recovery checks with older servers. This is re
Previous Message Atira Odhner 2017-01-30 15:17:24 Re: [Patch] Refactor sql template version picking