Re: clog double-dip in heap_hot_search_buffer

On Wed, May 2, 2012 at 5:07 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, May 2, 2012 at 12:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> +     /* Deleter committed, so tuple is alive if the XID is old enough. */
>>> +     return TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin);
>>
>> s/alive/dead/ in that comment?
>
> Yep, good catch, thanks.
>
>> Otherwise this seems like a good idea.
>
> Do you think I should apply this to 9.2, or wait until 9.3?

Now please. Well done.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services