Turning off hot_standby_feedback

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Turning off hot_standby_feedback
Date: 2013-02-03 22:25:09
Message-ID: CA+U5nMLQ1+UCqB2gb6kJ06R45NNn3-gGZsOn=nfmV4FqDoE-Xw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

There is a bug in hot_standby_feedback that causes the xmin of the
walsender process to not be reset when hot_standby_feedback is turned
off after it had previously sent at least one feedback message.

Clearly, that is a bad thing and deserves backpatching to 9.1, unless
I hear otherwise real soon.

Attached patch sends an immediate feedback message if it is turned off
on the standby. No protocol changes, just changes to how message is
handled and when it is sent.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
hs_feedback_off.v1.patch application/octet-stream 4.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-02-03 22:37:35 Re: [COMMITTERS] pgsql: Mark vacuum_defer_cleanup_age as PGC_POSTMASTER.
Previous Message Tom Lane 2013-02-03 21:57:27 Re: ALTER command reworks