Re: Assertion failure in syncrep.c

On 18 September 2014 07:32, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> wrote:

> 564 /*
> 565 * Set state to complete; see SyncRepWaitForLSN() for discussion
> of
> 566 * the various states.
> 567 */
> 568 thisproc->syncRepState = SYNC_REP_WAIT_COMPLETE;
> 569
> 570 /*
> 571 * Remove thisproc from queue.
> 572 */
> 573 SHMQueueDelete(&(thisproc->syncRepLinks));

Yes, looks like a bugette to me also.

Unlikely to occur except when no network involved, and even more
luckily no effect at all when Assert is not enabled. So not a priority
fix.

But fix looks trivial, just to switch around the two statements above.

I'll backpatch tomorrow.

Thanks

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services