| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
| Cc: | david(at)fetter(dot)org, andres(at)anarazel(dot)de, aidan(at)highrise(dot)ca, stark(at)mit(dot)edu, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: 16-bit page checksums for 9.2 |
| Date: | 2012-01-05 15:46:22 |
| Message-ID: | CA+U5nMKz7W_BpKw6-rUqqRObCQFYmR1ySZmRcnO-0tJkj=yfvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 4, 2012 at 1:35 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Simon Riggs wrote:
>
>> My focus was on getting something working first, then tuning. If
>> we're agreed that we have everything apart from the tuning then we
>> can proceed with tests to see which works better.
>
> Sure. I just think you are there already except for what I got into.
>
> FWIW, moving the modulus application out of the loop is a very
> trivial change and has no affect on the results; it's strictly a
> performance issue.
New version attached, with your suggested changes included. Hole check
code is there as well, but ifdef'd out since it isn't a valid check in
all cases.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| checksum16.v3.patch | text/x-patch | 22.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-01-05 16:04:38 | Re: CLOG contention |
| Previous Message | Tom Lane | 2012-01-05 15:44:28 | Re: pg_restore direct to database is broken for --insert dumps |