Re: ALTER TABLE lock strength reduction patch is unsafe Reply-To:

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe Reply-To:
Date: 2014-03-22 07:31:00
Message-ID: CA+U5nMKihfhazYtQFmYSw1a4DHVD5dv91dMh4HPnZ=FZOTGEfA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21 March 2014 23:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> On 21 March 2014 20:58, Noah Misch <noah(at)leadboat(dot)com> wrote:
>>> It's not the behavior I would choose for a new product, but I can't see
>>> benefits sufficient to overturn previous decisions to keep it.
>
>> Speechless
>
> The key argument for not "fixing" this is that it would break existing
> pg_dump files. That's a pretty hard argument to overcome, unfortunately,
> even if you're willing to blow off the possibility that client
> applications might contain similar shortcuts. We still do our best to
> read dump files from the 7.0 era (see ConvertTriggerToFK() for one example
> of going above and beyond for that); and every so often we do hear of
> people trying to get data out of such ancient servers. So even if you
> went and fixed pg_dump tomorrow, it'd probably be ten or fifteen years
> before people would let you stop reading dumps from existing versions.

Noah had already convinced me, but thank you for explaining the issue
behind that.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-03-22 07:36:02 Re: ALTER TABLE lock strength reduction patch is unsafe Reply-To:
Previous Message Michael Paquier 2014-03-22 06:32:45 Re: Patch for CREATE RULE sgml -- Was in: [DOCS]