| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, Daniel Farina <daniel(at)heroku(dot)com>, Chris Redekop <chris(at)replicon(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hot Backup with rsync fails at pg_clog if under load |
| Date: | 2011-10-27 15:25:25 |
| Message-ID: | CA+U5nMKgGZu-esbTiOL5che6f5ENZPdZSpScaEEmRx_9J2Y02A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 27, 2011 at 3:13 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> However, the
> obvious next question is whether those other modules don't need to be
> changed also, and if not why not.
Good point.
StartupSubtrans() is also changed by this patch, since it will be
supplied with an earlier initialisation value.
StartupMultiXact() didn't need changing, I thought, but I will review further.
> Another issue is that if StartupCLog is left as a no-op, what will
> happen if someone mistakenly tries to access clog before the trim
> function is called? It would be a good idea to make sure that such
> a thing results in an easily-identifiable failure.
The old StartupCLOG() didn't do anything that was essential to using
the clog, which is why its a no-op.
You can still use the clog, just with zero startup.
Maybe setting the current page should go in at startup, will think.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2011-10-27 15:41:58 | out-of-order caution |
| Previous Message | Dimitri Fontaine | 2011-10-27 15:14:14 | Re: Updated version of pg_receivexlog |