Re: ALTER TABLE ... ALTER CONSTRAINT

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE ... ALTER CONSTRAINT
Date: 2013-06-24 21:17:14
Message-ID: CA+U5nMKVCsn0ckF4hgExF0JJxw-BsNvx3wsGe4rOEuO=FOmj1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24 June 2013 21:42, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:

> On Sun, Jun 23, 2013 at 8:58 PM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>wrote:
>
>> At 2013-06-08 21:45:24 +0100, simon(at)2ndQuadrant(dot)com wrote:
>> >
>> > ALTER TABLE foo
>> > ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE;
>>
>> I read the patch (looks good), applied it on HEAD (fine), ran make check
>> (fine), and played with it in a test database. It looks great, and from
>> previous responses it's something a lot of people have wished for.
>>
>> I'm marking this ready for committer.
>>
>
> After the commit, I'm now getting the compiler warning:
>
> tablecmds.c: In function 'ATPrepCmd':
> tablecmds.c:2953: warning: 'pass' may be used uninitialized in this
> function
>
>
> case AT_AlterConstraint (line 3130) is the only case branch that does not
> set pass.
>

The investigation is into why my current compiler didn't report that.
Thanks though.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-06-24 21:21:06 Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
Previous Message Kevin Grittner 2013-06-24 21:16:01 Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]