From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
Cc: | robertmhaas(at)gmail(dot)com, josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review] |
Date: | 2012-12-23 14:41:24 |
Message-ID: | CA+U5nMKJw6fEduwb6LZKkiBZAjAe6m7+5boaZFEa6jM5EZyo0Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 20 December 2012 14:56, Amit Kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
>> > 1. There is no performance change for cloumns that have all valid
>> > values(non- NULLs).
I don't see any tests (at all) that measure this.
I'm particularly interested in lower numbers of columns, so we can
show no regression for the common case.
>> > 2. There is a visible performance increase when number of columns
>> containing
>> > NULLS are more than > 60~70% in table have large number of columns.
>> >
>> > 3. There are visible space savings when number of columns containing
>> NULLS
>> > are more than > 60~70% in table have large number of columns.
Agreed.
I would call that quite disappointing though and was expecting better.
Are we sure the patch works and the tests are correct?
The lack of any space saving for lower % values is strange and
somewhat worrying. There should be a 36? byte saving for 300 null
columns in an 800 column table - how does that not show up at all?
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Erik Rijkers | 2012-12-23 14:57:15 | Re: [WIP] pg_ping utility |
Previous Message | Fujii Masao | 2012-12-23 14:37:04 | Re: Switching timeline over streaming replication |