| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: heap vacuum & cleanup locks |
| Date: | 2011-11-03 13:52:00 |
| Message-ID: | CA+U5nMK33o5RV56TbCOC91hrqWGHsMYAgkq_PUO_icrqgVz8RQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 3, 2011 at 1:26 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I think that should be OK, but:
>
> - It looks to me like you haven't done anything about the second heap
> pass. That should probably get a similar fix.
I was assuming this worked with Pavan's patch to remove second pass.
Not in any rush to commit this, so will wait till that is thru.
> - I think that this is going to screw up the reltuples calculation
> unless we fudge it somehow. The number of scanned pages has already
> been incremented by the time your new code is reached.
Yeh, I'll have a look at that in more detail. Thanks for the review.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Klaver | 2011-11-03 14:00:30 | Re: Strange problem with create table as select * from table; |
| Previous Message | Robert Haas | 2011-11-03 13:26:59 | Re: heap vacuum & cleanup locks |