| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: corrupt pages detected by enabling checksums |
| Date: | 2013-04-11 08:50:15 |
| Message-ID: | CA+U5nMK0K4zaeGaPLJdyJSWz+=h7azrawm9XzJApsxU1P=Q+xQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11 April 2013 00:37, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Apr 6, 2013 at 10:44 AM, Andres Freund <andres(at)2ndquadrant(dot)com>
> wrote:
> > I feel pretty strongly that we shouldn't add any such complications to
> > XLogInsert() itself, its complicated enough already and it should be
> > made simpler, not more complicated.
>
> +1, emphatically. XLogInsert is a really nasty scalability
> bottleneck. We need to move as much logic out of that function as
> possible, and particularly out from under WALInsertLock.
>
Andres' patch was applied, so not sure what you mean by +1ing a comment
made in relation to that patch.
I'm aware that WALInsertLock is a bottleneck and am not going to be making
that worse.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ants Aasma | 2013-04-11 10:22:24 | Re: Inconsistent DB data in Streaming Replication |
| Previous Message | Gurjeet Singh | 2013-04-11 08:07:41 | Re: [DOCS] synchronize_seqscans' description is a bit misleading |