| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Joachim Wieland <joe(at)mcknight(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: posix_fadvise missing in the walsender |
| Date: | 2013-02-19 22:48:08 |
| Message-ID: | CA+U5nMK=MBJ3xKzCGkxcMeRzdEnT7wC6LdQeVGF3=Eg8kxcCrw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19 February 2013 20:19, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>>> In access/transam/xlog.c we give the OS buffer caching a hint that we
>>> won't need a WAL file any time soon with
>>>
>>> posix_fadvise(openLogFile, 0, 0, POSIX_FADV_DONTNEED);
>>>
> If that's the case, why have the advisory call at all? The OS is
> being lied too (in some cases)...
I agree with Merlin and Joachim - if we have the call in one place, we
should have it in both.
This means that if a standby fails it will likely have to re-read
these files from disk. Cool, we can live with that.
Patch please,
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-02-19 23:32:51 | Re: Materialized views WIP patch |
| Previous Message | Kevin Grittner | 2013-02-19 22:47:24 | Re: Materialized views WIP patch |