| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Allow external recovery_config_directory |
| Date: | 2013-03-27 21:36:17 |
| Message-ID: | CA+U5nMJe+Oxso++m1JyrkzLtwZMXMQrYRhdAuPzp0RVcc-w_gw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 27 March 2013 21:05, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:
>> Same argument applies to all conf files, not just recovery.conf.
>>
>> Sounds like the patch to add -R to pg_basebackup should be revoked as
>> being not well thought out. Or it should be fixed, in which case this
>> works the same.
>
> What exactly was wrong with pg_basebackup -R, without
> recovery_config_directory?
You asked me to answer the question. I did. Please answer mine.
Why do you think recovery_config_directory are different to
config_file with respect to pg_basebackup?
It looks like you've discovered a problem with pg_basebackup, not a
problem with this patch.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2013-03-27 21:37:51 | Re: pgsql: Fix pasto which broke docs build. |
| Previous Message | Kevin Grittner | 2013-03-27 21:20:56 | Re: [COMMITTERS] pgsql: Allow external recovery_config_directory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2013-03-27 21:42:08 | Re: Catching resource leaks during WAL replay |
| Previous Message | Kevin Grittner | 2013-03-27 21:20:56 | Re: [COMMITTERS] pgsql: Allow external recovery_config_directory |