From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fast promotion, loose ends |
Date: | 2013-04-24 08:46:06 |
Message-ID: | CA+U5nMJRtoz=3zsp6n4K8e-NRJQ7nojiBuO+1tB-POonTROJDA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 24 April 2013 09:32, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:
>> pg_ctl already checks versions, so I don't see the point.
>
>
> The point is, if you do "pgsql93/bin/pg_ctl -D $92DATADIR promote", it will
> create fast_promote file and return success. But it won't actually promote
> the server. I think that's bad.
>
> If pg_ctl already has a check against that, fine, but I don't think it does.
> Please make sure you test that before applying.
If it doesn't check, that is not the only thing that would be broken.
The original commit of pg_ctl promote would also be broken.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2013-04-24 08:53:58 | Re: Fast promotion, loose ends |
Previous Message | KONDO Mitsumasa | 2013-04-24 08:43:39 | Failing start-up archive recovery at Standby mode in PG9.2.4 |