From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Implement ALTER TABLE .. SET LOGGED / UNLOGGED |
Date: | 2014-08-23 16:28:38 |
Message-ID: | CA+U5nMJJtjL7e5+CgsdNhgCyqR8vcfFZeQpvPs49oV5m7mnLvw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 23 August 2014 14:57, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On August 23, 2014 3:49:32 PM CEST, Simon Riggs <simon(at)2ndQuadrant(dot)com> wrote:
>>On 22 August 2014 19:30, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
>>wrote:
>>
>>> Implement ALTER TABLE .. SET LOGGED / UNLOGGED
>>>
>>When moving from unlogged to logged, where do we remove the init fork?
>>
>>Couldn't see the keywords fork or init anywhere in the patch, so maybe
>>its hidden somewhere.
>
> A new relfilenode is filled with the data - the old one, including the init fork, gets removed by the normal mechanics of rewriting rels.
Why do we do that? Table rewrite takes hours.
If that is a requirement, I don't see it documented. If its a choice,
its a bad one.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-08-23 16:47:47 | Re: pgsql: Implement ALTER TABLE .. SET LOGGED / UNLOGGED |
Previous Message | Andres Freund | 2014-08-23 13:57:53 | Re: pgsql: Implement ALTER TABLE .. SET LOGGED / UNLOGGED |