Re: BUG #7710: Xid epoch is not updated properly during checkpoint

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: tarvip(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org, Andres Freund <andres(at)2ndquadrant(dot)com>
Subject: Re: BUG #7710: Xid epoch is not updated properly during checkpoint
Date: 2012-12-02 15:58:25
Message-ID: CA+U5nMJ7mUqRoUwHEKu1r6Nzz0CUduKe30rDTYV++U--vAG7hw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2 December 2012 15:25, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> I can point right now to one misbehavior this causes: if you run a
> point-in-time recovery with a stop point somewhere in the middle of the
> checkpoint, you should end up with a nextXid corresponding to the stop
> point. This hack in LogStandbySnapshot causes you to end up with a
> much later nextXid, if you were running hot-standby.

True, though that does not cause any problem.

>> Others may wish to go further, overriding my patches, as they choose.
>
> Okay, I will take the responsibility for changing this, but it needs to
> change.

OK. At least we have the minimal coding to fall back on if need be.

> This coding was ill-considered from the word go.

Agreed, but then I don't have a clear reason why it is that way and
yet I'm sure I did it for some reason.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2012-12-02 16:44:32 Re: BUG #7710: Xid epoch is not updated properly during checkpoint
Previous Message Tom Lane 2012-12-02 15:25:20 Re: BUG #7710: Xid epoch is not updated properly during checkpoint