| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Ants Aasma <ants(at)cybertec(dot)at> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Smith <greg(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Subject: | Re: Substituting Checksum Algorithm (was: Enabling Checksums) |
| Date: | 2013-04-30 11:46:04 |
| Message-ID: | CA+U5nM+vAdcY3DK=spV04NmYNTq6XRXMbjie9mYrrT4MpP8svA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 30 April 2013 12:23, Ants Aasma <ants(at)cybertec(dot)at> wrote:
>> ISTM that we also need this patch to put memory barriers in place
>> otherwise the code might be rearranged.
>
> The compiler and CPU both have to preserve correctness when
> rearranging code, so I don't think we care about it here. It might
> matter if these routine could be called concurrently by multiple
> backends for a single buffer, but in that case memory barriers won't
> be enough, we'd need full exclusion.
Certainly happy not to commit anything else...
Thanks to Ants and Andres.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2013-04-30 12:19:33 | Re: The missing pg_get_*def functions |
| Previous Message | Joel Jacobson | 2013-04-30 11:34:44 | Re: The missing pg_get_*def functions |