Re: Record previous TLI in end-of-recovery record (was Re: [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.)

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Record previous TLI in end-of-recovery record (was Re: [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.)
Date: 2013-02-07 16:24:55
Message-ID: CA+U5nM+unoR960REbyMt57=WDdzk-k6pn_-K1Din0Q173kpEJg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 7 February 2013 16:07, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:

> It just occurred to me that it would be really nice if the end-of-recovery
> record, and the timeline-switching shutdown checkpoint record too for that
> matter, would include the previous timeline's ID that we forked from, in
> addition to the new TLI. Although it's not required for anything at the
> moment, it would be useful debugging information. It would allow
> reconstructing timeline history files from the WAL; that might come handy.
>
> Barring objections, I'll add that.

Good idea, please do.

That means a shutdown checkpoint becomes it's own record type.... but
my understanding of our other conversations was that you want to never
use shutdown checkpoints for end of recovery ever again, so that seems
unnecesary. Sorry to mix things up.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2013-02-07 16:34:36 pgsql: Rely only on checkpoint 1 at end of recovery.
Previous Message Heikki Linnakangas 2013-02-07 16:07:44 Record previous TLI in end-of-recovery record (was Re: [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.)

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2013-02-07 16:32:04 Re: proposal: ANSI SQL 2011 syntax for named parameters
Previous Message Heikki Linnakangas 2013-02-07 16:07:44 Record previous TLI in end-of-recovery record (was Re: [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.)