From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: should we add a XLogRecPtr/LSN SQL type? |
Date: | 2013-12-12 13:20:51 |
Message-ID: | CA+U5nM+oy9TSs+4fc3r_hfY6nC_CPVN4GDun7vXPTjromhEQ2Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12 December 2013 12:27, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2013-12-11 08:13:18 -0500, Robert Haas wrote:
>> On Wed, Dec 11, 2013 at 7:41 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> > There's already a couple of SQL function dealing with XLogRecPtrs and
>> > the logical replication work will add a couple of more. Currently each
>> > of those funtions taking/returning an LSN does sprintf/scanf to
>> > print/parse the strings. Which both is awkward and potentially
>> > noticeable performancewise.
>> >
>> > It seems relatively simple to add a proper type, with implicit casts
>> > from text, instead?
>>
>> I'm pretty sure that this was discussed last year, and I voted for it
>> but more people
>> voted against it, so it died. I still think that was a mistake, but I
>> just work here.
>
> Ah. I missed or forgot that discussion.
Hmm, don't recall that. Just in case I opposed it, its a good idea now.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Mitsumasa KONDO | 2013-12-12 13:43:02 | Re: Optimize kernel readahead using buffer access strategy |
Previous Message | Simon Riggs | 2013-12-12 13:17:51 | Re: Optimize kernel readahead using buffer access strategy |