| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WAL Rate Limiting |
| Date: | 2014-01-20 17:27:26 |
| Message-ID: | CA+U5nM+kLgwhvABZqNfYqQDAM9AjaVSDY_NWXPcbxH8Dd=pQxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17 January 2014 16:34, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:
> On 01/17/2014 05:20 PM, Simon Riggs wrote:
>>
>> + if (RelationNeedsWAL(indexrel))
>> + CHECK_FOR_WAL_BUDGET();
>
>
> I don't think we need the RelationNeedsWAL tests. If the relation is not
> WAL-logged, you won't write much WAL, so you should easily stay under the
> limit. And CHECK_FOR_WAL_BUDGET() better be cheap when you're below the
> limit.
OK, I'll remove them, thanks.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-01-20 17:37:47 | Re: WAL Rate Limiting |
| Previous Message | Fujii Masao | 2014-01-20 17:27:06 | Re: Comment typo in src/backend/command/cluster.c |