| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove regression test added on auto-pilot. |
| Date: | 2015-07-15 14:19:01 |
| Message-ID: | CA+TgmobxzDyu2tq8U3Qqj7=ORHYHghT0hxs4cXtCi9wO1G5rPg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Jul 15, 2015 at 4:06 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-07-14 20:30:41 +0000, Robert Haas wrote:
>> Remove regression test added on auto-pilot.
>>
>> Test does not match the comment which precedes it.
>
> Not important enough to revert, but imo it makes perfect sense to test
> both the aliased and non-aliased version of a the otherwise unmodified
> query.
Yeah, that's what I thought too, but Peter seemed to feel that it was
better not to have a regression test there that didn't match the
comment, and I figured that there were probably various test cases for
aliasing elsewhere. So I went with it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2015-07-16 01:02:08 | pgsql: AIX: Link the postgres executable with -Wl,-brtllib. |
| Previous Message | Alvaro Herrera | 2015-07-15 14:11:46 | pgsql: Mention table_rewrite as valid event trigger tag |