| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel bitmap heap scan |
| Date: | 2017-02-14 03:45:56 |
| Message-ID: | CA+Tgmobxw-EW=LU9pzW835SFB0ukW_mCksof95tjd5i6mpe5=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 13, 2017 at 8:48 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> On Mon, Feb 13, 2017 at 6:24 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I don't think it's acceptable (or necessary) to move the DSA
>> definitions into postgres.h. Why do you think you need to do that,
>> vs. just including dsa.h in a few more places?
>
> I need to access dsa_pointer in tidbitmap.h, which is included from
> FRONTEND as well. Now, problem is that dsa.h is including #include
> "port/atomics.h", but atomic.h can not be included if FRONTEND is
> defined.
>
> #ifndef ATOMICS_H
> #define ATOMICS_H
> #ifdef FRONTEND
> #error "atomics.h may not be included from frontend code"
> #endif
>
> Is there any other solution to this ?
Well, any problem like this generally has a bunch of solutions, so
I'll say yes. I spent a good chunk of today studying the issue and
started a new thread devoted specifically to it:
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-14 03:50:43 | Re: Removal of deprecated views pg_user, pg_group, pg_shadow |
| Previous Message | Robert Haas | 2017-02-14 03:43:03 | Re: log_autovacuum_min_duration doesn't log VACUUMs |